Add traceId and spanId elements #372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@troosan Have you though about, the handling of traceId and spanId, maybe should be part of the |
Contributor
Author
|
I have created a first pull request for the refactoring of the test classes I'm thinking maybe I could create a generic MdcExtractor, which would allow to configure whatever MDC field to be moved/copied to another field. Would that do it? |
troosan
force-pushed
the
feature/add-traceId-and-spanId
branch
from
91eea8d to
3d90469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are 2 different commits
Let me know if you prefer I create 2 separate PRs